Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] FGNet interface changes to match VisionDataset #78

Merged
merged 10 commits into from
Jul 23, 2024
Merged

[API] FGNet interface changes to match VisionDataset #78

merged 10 commits into from
Jul 23, 2024

Conversation

franberchez
Copy link
Contributor

@franberchez franberchez commented Jul 17, 2024 •
edited
Loading

  • VisionDataset inheritance has been corrected.
  • Override of __getitem__ and __len__ methods.
  • New class attributes such as train, transform and target_transform have been included.
  • Two new class properties have been added, namely targets and classes.
  • Test improvement.
  • Tutorials correction.

@franberchez franberchez added the enhancement New feature or request label Jul 17, 2024
@franberchez franberchez requested a review from victormvy July 17, 2024 11:37
@franberchez franberchez self-assigned this Jul 17, 2024
@victormvy victormvy changed the title [ENH] FGNet improvement to work as a torchvision dataset [API] FGNet interface changes to match VisionDataset Jul 20, 2024
@victormvy victormvy added API design API design & software architecture and removed enhancement New feature or request labels Jul 20, 2024
victormvy
victormvy requested changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@victormvy victormvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial associated with the datasets should be updated accordingly

@franberchez franberchez merged commit 728e643 into development Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victormvy victormvy victormvy approved these changes

Assignees

@franberchez franberchez

Labels
API design API design & software architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franberchez @victormvy