Feature/kak/grid to list#15 #80
Conversation
|
Although filters are now preserved on screen rotation, they are not preserved on back navigation. That might call for a separate issue. |
|
Now that we have the ability to start a filterable activity with a filter already set, it would be good to carry the filter over when moving from events<->destinations or list<->map. I imagine it would be pretty small to tack that onto this PR, but opening another issue to tackle it later would be fine too. |
|
I don't think it will be that straightforward to manage back navigation if it's not working already with existing lifecycle events; it may require shared preferences storage. Created #81. See link to discussion on the issue. |
Actually, back navigation is working fine! I meant when tapping the "map" icon it would be nice to carry the current filter into the map activity when we call |
There was a problem hiding this comment.
Mostly looking pretty good! Some great refactors in here 🎉
I'd like to see the "No results" layout regression fixed before merging this.
It would be nice to get the category names into string resources and to carry the filter through when going from the list -> map activities, but those can be deferred for now if you'd like.
| public static final String LIKED = "Places you like"; | ||
|
|
||
|
|
||
| // FIXME: reference user-facing strings (displayName) as strings resources |
There was a problem hiding this comment.
It would be nice to get this cleaned up as part of this PR.
Instead of a string field in the enum options, we could replace it with a @StringRes int field and leave it to the user of the enum to turn that into an actual string as-needed.
Probably fine to continue to using string constants for the dbName field.
| android:gravity="center" | ||
| android:text="@string/filter_no_results" | ||
| android:visibility="gone" | ||
| app:layout_constraintTop_toBottomOf="@+id/places_list_app_bar" /> |
There was a problem hiding this comment.
This isn't placed correctly - it shows up in the top-left hidden underneath the toolbar.
I'm guessing by the app:layout_constraintTop_toBottomOf attribute that you intended to add a ConstraintLayout to this layout?
There was a problem hiding this comment.
Close, I'd removed a ConstraintLayout.
|
Okay, back navigation preserves the filter, but up navigation does not. I think that should be fine. Created #81 |
|
Updated; this should be ready for another look. |
|
Looks good! We should probably wait to merge this until #79 is merged. |
Due to nested RecyclerView.
Also convert to constraint layout. Closes azavea#29.
Get and set random image for each home view filter button category.
Save and restore filters on list view rotation. Fixes azavea#78.
Fix last item in list being cut off/not scrolling to bottom.
Implement filtering on click of grid button on home view. Closes azavea#15.
Also modify events list message to match formatting.
Move strings for home page fitler buttons to string resources.
flibbertigibbet
force-pushed
the
feature/kak/grid-to-list#15
branch
from
a800f2b
to
4c03083
Compare
Overview
Implements the grid of buttons on the home view. Loads a random representative image for each category into the category's grid square, or hides the category's grid square if nothing matches its filter. Opens place view with filter in place.
Also fixes filters being lost on screen rotation and implements scrolling of the home view carousel with the grid content.
Demo
Notes
Does not attempt to ensure the images picked are unique; in practice currently, duplicates seem to be fairly uncommon.
Implements filtering by database query, as the original filtering implementation relied on string searches outside the database.
Closes #15
Fixes #78
Fixes #29