Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick milestone fixes #909

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Quick milestone fixes #909

merged 4 commits into from
Aug 30, 2021

Conversation

jisantuc
Copy link
Contributor

Overview

This PR adds a few quick fixes to support the first tagged release. It:

  • Adds request logging in a nice json format that plays nicely with cloud service logs parsers
  • Adds a cascade to the item reference on histograms so items that you put in a histogram can ever be deleted
  • Returns a 404 instead of an empty tile with a 200 when you make a request for a mosaic that's not in a collection
  • Includes the limit value in the search context property

Checklist

  • New tests have been added or existing tests have been modified These things aren't really testable aside from "didn't break the server", which is exercised in existing tests, mostly, except for mosaics, which have their own "figure out how to test this better" issue (Properly test mosaic routes #829)

Testing Instructions

  • just CI

Closes #255

Closes #884

Closes #859

Closes #793

@jisantuc jisantuc force-pushed the feature/js/milestone-quick-fixes branch from 1f492ad to fe0daf8 Compare August 30, 2021 22:55
@jisantuc jisantuc merged commit 3ed46f7 into master Aug 30, 2021
@jisantuc jisantuc deleted the feature/js/milestone-quick-fixes branch August 30, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant