Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magicKey breaking ESRI geocoding #68

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Fix magicKey breaking ESRI geocoding #68

merged 5 commits into from
Jan 22, 2024

Commits on Jan 19, 2024

  1. Add test for magic key case

    This is currently failing, to replicate the bug reported in #67.
    Will add a fix for this next.
    rajadain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    2a134fb View commit details
    Browse the repository at this point in the history
  2. Tolerate missing Loc_name, warn if on missing keys

    Previously we assumed that Loc_name would always be provided, given
    that we ask for it in the requested field list. However, when using
    the magicKey, the Loc_name is not provided, causing geocoding to
    fail. By making it optional, we allow those geocoding requests to
    succeed.
    
    Also, add a WARNING to the log when there's a missing key, instead
    of just silently passing, for better observability.
    rajadain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ecf614a View commit details
    Browse the repository at this point in the history
  3. Add Locality to default filter

    This new value is used for many responses now, need to include it
    for the tests to pass.
    rajadain committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    09506e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    99f6963 View commit details
    Browse the repository at this point in the history
  2. Address failing tests

    Disable Google test if credentials are missing.
    
    Not sure what was wrong with the Philadelphia address for Census
    purposes, but switching to an Alexandria address fixes that.
    rajadain committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    de75706 View commit details
    Browse the repository at this point in the history