remove zig port (from master)

.github/workflows/build.yaml

@@ -14,12 +14,6 @@ jobs:
           authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}"
       - name: Build Nix
         run: nix build -j8 .#devShells.x86_64-linux.default
-      - name: Zig Cache
-        uses: actions/cache@v4
-        with:
-          path: rose-zig/zig-cache
-          key: ${{ runner.os }}-rose-zig
-          save-always: true
       - name: Typecheck
         if: success() || failure() # Means that we run all steps even if one fails.
         run: nix develop --command make typecheck

Makefile

@@ -1,22 +1,13 @@
 check: typecheck test lintcheck
 
-# Build the Zig library for development.
-build-zig:
-	cd rose-zig && zig build -Doptimize=Debug
-
-typecheck: build-zig
+typecheck:
 	mypy .
 
-test-py: build-zig
+test:
 	pytest -n logical .
 	coverage html
 
-test-zig:
-	cd rose-zig && zig build test --summary all
-
-test: test-zig test-py 
-
-snapshot: build-zig
+snapshot:
 	pytest --snapshot-update .
 
 lintcheck:
@@ -32,7 +23,4 @@ lint:
 clean:
 	git clean -xdf
 
-nixify-zig-deps:
-	cd rose-zig && zon2nix > deps.nix
-
-.PHONY: check build-zig test-py test-zig test typecheck lintcheck lint clean nixify-zig-deps
+.PHONY: check test typecheck lintcheck lint clean

flake.nix

@@ -35,7 +35,6 @@
         inherit
           # Runtime deps.
           appdirs
-          cffi
           click
           jinja2
           llfuse
@@ -69,7 +68,6 @@
             echo "$path"
           }
           export ROSE_ROOT="$(find-up flake.nix)"
-          export ROSE_SO_PATH="$ROSE_ROOT/rose-zig/zig-out/lib/librose.so"
           export PYTHONPATH="$ROSE_ROOT/rose-py:''${PYTHONPATH:-}"
           export PYTHONPATH="$ROSE_ROOT/rose-watch:$PYTHONPATH"
           export PYTHONPATH="$ROSE_ROOT/rose-vfs:$PYTHONPATH"
@@ -82,23 +80,20 @@
               pkgs.ruff
               pkgs.nodePackages.pyright
               pkgs.nodePackages.prettier
-              pkgs.zig
-              pkgs.zls
               python-with-deps
               zon2nix
             ];
           })
         ];
       };
       packages = rec {
-        rose-zig = pkgs.callPackage ./rose-zig { inherit version; };
-        rose-py = pkgs.callPackage ./rose-py { inherit version python-pin py-deps rose-zig; };
+        rose-py = pkgs.callPackage ./rose-py { inherit version python-pin py-deps; };
         rose-watch = pkgs.callPackage ./rose-watch { inherit version python-pin py-deps rose-py; };
         rose-vfs = pkgs.callPackage ./rose-vfs { inherit version python-pin py-deps rose-py; };
         rose-cli = pkgs.callPackage ./rose-cli { inherit version python-pin py-deps rose-py rose-vfs rose-watch; };
         all = pkgs.buildEnv {
           name = "rose-all";
-          paths = [ rose-zig rose-py rose-watch rose-vfs rose-cli ];
+          paths = [ rose-py rose-watch rose-vfs rose-cli ];
         };
       };
     });

pyproject.toml

@@ -89,9 +89,6 @@ ignore_missing_imports = true
 [[tool.mypy.overrides]]
 module = "snapshottest"
 ignore_missing_imports = true
-[[tool.mypy.overrides]]
-module = "cffi"
-ignore_missing_imports = true
 
 [tool.pytest.ini_options]
 addopts = [

rose-cli/rose_cli/cli.py

@@ -119,14 +119,6 @@ def version() -> None:
     click.echo(VERSION)
 
 
-@cli.command()
-def tmp() -> None:
-    """Temporary development command for FFI testing. If you see this, it's a bug."""
-    from rose.ffi import get_release
-
-    print(get_release())
-
-
 @cli.group()
 def config() -> None:
     """Utilites for configuring Rosé."""

rose-cli/rose_cli/cli_test.py

@@ -6,7 +6,6 @@
 import pytest
 from click.testing import CliRunner
 from rose import AudioTags, Config
-from rose.ffi import get_release
 from rose_vfs.virtualfs_test import start_virtual_fs
 
 from rose_cli.cli import (
@@ -126,7 +125,3 @@ def mock_exit(x: int) -> None:
     # Assert that we can't kill a non-existent watchdog.
     res = runner.invoke(unwatch, obj=ctx)
     assert res.exit_code == 1
-
-
-def test_ffi() -> None:
-    assert get_release() == "hello"

rose-py/default.nix

@@ -1,17 +1,14 @@
 { python-pin
 , version
 , py-deps
-, rose-zig
 }:
 
 python-pin.pkgs.buildPythonPackage {
   pname = "rose";
   version = version;
   src = ./.;
   propagatedBuildInputs = [
-    rose-zig
     py-deps.appdirs
-    py-deps.cffi
     py-deps.click
     py-deps.jinja2
     py-deps.mutagen
@@ -20,5 +17,4 @@ python-pin.pkgs.buildPythonPackage {
     py-deps.uuid6
   ];
   doCheck = false;
-  ROSE_SO_PATH = "${rose-zig}/lib/librose.so";
 }