Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all tracks & remove _delete_this #121

Merged
merged 12 commits into from
May 6, 2024
Merged

all tracks & remove _delete_this #121

merged 12 commits into from
May 6, 2024

Conversation

azuline
Copy link
Owner

@azuline azuline commented May 6, 2024 •
edited
Loading

closes #102 and #120

  • add new to rule engine
  • write new tests
  • optimize fast search paths

@azuline azuline changed the title templating all tracks & remove _delete_this May 6, 2024
@azuline azuline mentioned this pull request May 6, 2024
Closed
@azuline azuline linked an issue May 6, 2024 that may be closed by this pull request
Optimize happy paths in find_releases/tracks_with_matcher and use in vfs #120
Closed
@azuline
Copy link
Owner Author

azuline commented May 6, 2024

might want to parse the pattern so that it is easy to compare... strictstart: bool, strictend: bool, needle: str and then if/when we add the boolean things, we can ==. but not necessary right now

as long as we add new to the ruleparser.

@azuline azuline marked this pull request as ready for review May 6, 2024 16:43
@azuline azuline merged commit 80617d0 into master May 6, 2024
1 check passed
@azuline azuline deleted the all-tracks-and-fast-search branch May 6, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@azuline