Skip to content

Commit

Permalink
Fix New Years Day tests of South Korea.
Browse files Browse the repository at this point in the history
The holiday 'twoDaysLaterNewYearsDay' has been removed from 1990,
however the unit test for the name and holiday type allowed the possible
testing range to include the year 1990.

Signed-off-by: Sacha Telgenhof <me@sachatelgenhof.com>
  • Loading branch information
stelgenhof committed Dec 3, 2023
1 parent 0067415 commit 3b49432
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/SouthKorea/NewYearsDayTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function testTranslation(): void
$this->assertTranslatedHolidayName(
self::REGION,
'twoDaysLaterNewYearsDay',
$this->generateRandomYear(self::ESTABLISHMENT_YEAR, 1990),
$this->generateRandomYear(self::ESTABLISHMENT_YEAR, 1989),
[self::LOCALE => '새해 연휴']
);
}
Expand All @@ -149,7 +149,7 @@ public function testHolidayType(): void
$this->assertHolidayType(
self::REGION,
'twoDaysLaterNewYearsDay',
$this->generateRandomYear(self::ESTABLISHMENT_YEAR, 1990),
$this->generateRandomYear(self::ESTABLISHMENT_YEAR, 1989),
Holiday::TYPE_OFFICIAL
);
}
Expand Down

0 comments on commit 3b49432

Please sign in to comment.