Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PHPUnit): Increased memory_limit, to be able to run all tests on MacOS #336

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

fbett
Copy link
Contributor

@fbett fbett commented Apr 10, 2024

Reason:
128M was not enough to run all unit tests

The expected memory usage seems to be between 180M (MacOS M3) and 350M (Github's Workflow Runner)

Previous #335

@stelgenhof
Copy link
Member

@fbett Your code is failing because of new PHP CS rules. Please run the following on your PR/branch:
composer cs-fix. And also run the tests locally first before committing: composer test.

When all is without errors, please commit. Then it should be good! :)

@fbett
Copy link
Contributor Author

fbett commented Apr 10, 2024

This PR does not contain any code - only a small appendix to the phpunit config file.

If i run composer cs-fix on the develop branch, the script modifies more than 1600 files.
Please run the commands on the develop branch to prevent problems like this.

@stelgenhof
Copy link
Member

stelgenhof commented Apr 10, 2024

@fbett Yes correct, I was thinking of your other PR. Anyway, the develop branch is already up to date. You just need to rebase your branch.

@fbett
Copy link
Contributor Author

fbett commented Apr 10, 2024

No, the develop branch is not up to date. I have already created a new fork.

@stelgenhof
Copy link
Member

Apologies, you're correct (sorry long day). I will update the develop branch right away.

@fbett fbett force-pushed the memory-limit-512 branch from 109bba4 to 3116e5f Compare April 11, 2024 06:11
@fbett
Copy link
Contributor Author

fbett commented Apr 11, 2024

Thank you. The commit is rebased.

@stelgenhof stelgenhof merged commit 1f8fca6 into azuyalabs:develop Apr 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants