Fix reserved label cause inifity loop

ba0f3 · Sep 22, 2022 · 6647ca8 · 6647ca8
1 parent 478c268
commit 6647ca8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/dnsclient.nimble b/dnsclient.nimble
@@ -1,6 +1,6 @@
 # Package
 
-version       = "0.3.0"
+version       = "0.3.1"
 author        = "Huy Doan"
 description   = "Simple DNS Client & Library"
 license       = "MIT"

diff --git a/src/dnsclientpkg/utils.nim b/src/dnsclientpkg/utils.nim
@@ -40,7 +40,7 @@ proc getName*(data: StringStream): string =
     kind = LabelType(length and TYPE_MASK)
     case kind
     of TYPE_INDIR:
-      # lenght is first octet << 8 + last octet
+      # length is first octet << 8 + last octet
       offset = (length.uint16 shl 8 + data.readUint8()) xor 0xC000'u16
       lastPos = data.getPosition()
       data.setPosition(offset.int)
@@ -63,7 +63,7 @@ proc getName*(data: StringStream): string =
         break # last label was INDIR, stop the loop
     else:
       #reversed
-      discard
+      break
   result = if labels.len == 1: labels[0] else: labels.join(".")
 
 proc ipv4ToString*(ip: int32): string =