Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-mounting CID for Local Content #474

Closed
wesfloyd opened this issue Aug 11, 2022 · 9 comments
Closed

Auto-mounting CID for Local Content #474

wesfloyd opened this issue Aug 11, 2022 · 9 comments

Comments

@wesfloyd
Copy link
Contributor

wesfloyd commented Aug 11, 2022

ETA: 2023Q2

Feature request: when we dropped the local flag, we hashed the local content, saw if the content was available on IPFS and if it was, auto mounted the CID. If it wasn't, we uploaded it.

Per this conversation in the LabDAO integration grant planning doc:

It'd be amazing if when we dropped the local flag, we hashed the local content, saw if the content was available on IPFS and if it was, auto mounted the CID. If it wasn't, we uploaded it.
Can you add this as a bug and tag Phil/Luke/Enrico?

@wesfloyd
Copy link
Contributor Author

@philwinder @lukemarsden @enricorotundo for FYI

(@aronchick apologies for opening this bug a bit late!)

@enricorotundo enricorotundo mentioned this issue Aug 11, 2022
10 tasks
@aronchick
Copy link
Collaborator

No objection here to the functionality, but I think the auto mounting should be its own verb

@enricorotundo
Copy link
Contributor

enricorotundo commented Aug 17, 2022

Taking one step back here 🤔. Is the final goal saving user's time by sparing them the ipfs add step (e.g. cid=$(ipfs add --quiet ./testdata/grep_file.txt))?
If that's the case, why restrict this to local mode only?

We could extend --input-volumes CID:path to support <local-path>:path and auto-upload the local content automatically. This'll probably cause problems because classifying /ipfs/<CID>/path as CID and /foo/bar/ as local path is problematic (ipfs/go-path#54).

Another option is adding a new verb (e.g. --input-path <local-path>:path).

@aronchick
Copy link
Collaborator

Man i like this one a lot :) @enricorotundo

@aronchick aronchick moved this from Triage (Unprioritized) to Next Up (Prioritized) in Bacalhau Main Jan 12, 2023
@simonwo
Copy link
Contributor

simonwo commented Jan 16, 2023

The plan for the inline storage feature was definitely to enable exactly this -- allow users to specify a local directory and have it included in the job. See #1628

@simonwo
Copy link
Contributor

simonwo commented Feb 16, 2023

In progress at #1765.

@aronchick
Copy link
Collaborator

@simonwo did this get finished?

@simonwo
Copy link
Contributor

simonwo commented Jan 4, 2024

We never did #1765, which is still the MVP answer to this issue.

@wdbaruni
Copy link
Member

seems finished to me

@github-project-automation github-project-automation bot moved this from Next Up (Prioritized) to To Celebrate in Bacalhau Main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants