Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacalhau --local #437

Merged
merged 30 commits into from
Aug 12, 2022
Merged

bacalhau --local #437

merged 30 commits into from
Aug 12, 2022

Conversation

js-ts
Copy link
Contributor

@js-ts js-ts commented Aug 3, 2022

sample command

bacalhau docker run ubuntu echo hello --local
hello
it runs completely locally and needs docker and ipfs daemon running

TODO

  • Test stdout,
  • Test Input volume
  • Test Output Volume
  • Tests --local
  • Test GPU (can we test in CI?)

Part 2 (Write tests and additional features (In the next PR))

@js-ts js-ts marked this pull request as ready for review August 3, 2022 11:48
cmd/bacalhau/docker_run.go Show resolved Hide resolved
cmd/bacalhau/utils.go Show resolved Hide resolved
pkg/executor/util/utils.go Outdated Show resolved Hide resolved
pkg/executor/local/executor.go Outdated Show resolved Hide resolved
pkg/executor/local/executor.go Outdated Show resolved Hide resolved
pkg/local/utils.go Outdated Show resolved Hide resolved
pkg/local/utils.go Outdated Show resolved Hide resolved
@enricorotundo enricorotundo linked an issue Aug 5, 2022 that may be closed by this pull request
3 tasks
@enricorotundo enricorotundo added the type/enhancement Type: New features or enhancements to existing features label Aug 8, 2022
@enricorotundo
Copy link
Contributor

i’ve started thinking it’s going to be difficult to guarantee support for all the new fancy features (e.g. sharing) in --local

because we’d have to either reimplement/adapt logic to work in local mode, or mark it as “unsupported”

both are not so desirable

@enricorotundo

This comment was marked as outdated.

@js-ts js-ts merged commit 141be88 into main Aug 12, 2022
@wjam wjam deleted the bacalhau_local branch February 2, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: New features or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer --local flag to execute entire job locally
3 participants