Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug where indoor absolute humidity would have wrong value #999

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bachya
Copy link
Owner

@bachya bachya commented Jun 4, 2024

Describe what the PR does:

We were calculating outdoor and indoor absolute humidity using the same values.

Does this fix a specific issue?

Fixes #997

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Jun 4, 2024
@bachya bachya self-assigned this Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88cc736) to head (5a992ed).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #999   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1751      1761   +10     
=========================================
+ Hits          1751      1761   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bachya bachya merged commit f72d586 into dev Jun 4, 2024
11 checks passed
@bachya bachya deleted the bachya/fix-absolute-humidity-in branch June 4, 2024 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indoor absolute humidity from Gateway is the same as Outdoor
1 participant