Associate VolumeSnapshots with SnapshotSchedules via OwnerReferences #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salmon111 <kumachans@kumachans.net>
Signed-off-by: salmon111 <kumachans@kumachans.net>
salmon111
force-pushed
the
feat/ownerReferences
branch
from
bf1657e to
3513f2e
Compare
|
Hi @JohnStrunk, |
|
Thank you for taking the initiative to put something together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR addresses #359 by adding
OwnerReferencestoVolumeSnapshotobjects created bySnapshotSchedule.This ensures that
VolumeSnapshotsare automatically tracked and cleaned up when their parentSnapshotScheduleis deleted.The addition improves resource management and simplifies dependency handling.
Is there anything that requires special attention?
This feature can be enabled by setting
enableOwnerReferencesto true invalues.yaml.The default behavior remains unchanged even after the update.
Related issues: