use button id to identify if token is available

bacpop · Oct 5, 2023 · 4ba2ab7 · 4ba2ab7
1 parent 2ff083f
commit 4ba2ab7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/client/src/components/GenerateMicroreactURL.vue b/app/client/src/components/GenerateMicroreactURL.vue
@@ -3,6 +3,7 @@
     <div>
       <button
         v-if='!microreactToken'
+        id="generate-microreact-url-no-token-btn"
         @click='showModal()'
         class='btn btn-block btn-standard btn-download'
       >
@@ -11,6 +12,7 @@
 
       <button
         v-if='tokenAvailable'
+        id="generate-microreact-url-token-btn"
         @click='buildMicroreactURL({cluster, token: microreactToken})'
         class='btn btn-block btn-standard btn-download'
       >

diff --git a/app/client/tests/e2e/LoggedIn.spec.ts b/app/client/tests/e2e/LoggedIn.spec.ts
@@ -94,11 +94,11 @@ test.describe("Logged in Tests", () => {
         // Expect download buttons and button to generate microreact URL to appear
         await expectDownloadButtons("6930_8_13.fa", page);
 
+        // Token will be saved for user after first run of the test
+        const tokenAvailable = await page.isVisible("#generate-microreact-url-token-btn");
         await page.click("text=Generate Microreact URL");
 
-        // Token will be saved for user after first run of the test
-        const modal = await page.isVisible(".modalFlex");
-        if (modal) {
+        if (!tokenAvailable) {
             await expect(page.locator(".modalFlex")).toContainText("No token submitted yet");
             await expect(page.locator(".modalFlex .btn")).toContainText("Save token");
             // after submitting microreact token, button turns into link to microreact.org