Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacpop-110 Persist Microreact tokens #41

Closed
wants to merge 13 commits into from
Closed

bacpop-110 Persist Microreact tokens #41

wants to merge 13 commits into from

Conversation

EmmaLRussell
Copy link
Collaborator

@EmmaLRussell EmmaLRussell commented Sep 26, 2023

This branch persists microreact token when user enters one, sending it to the back end to be saved in the redis db, encrypted using the crypto package.

When the user logs in, any token is fetched, and this will be used next time they generate a Microreact url, rather than requiring them to re-enter their token after each log in.

This means the user doesn't currently have any way to delete or change their token - this will be done in a separate ticket: https://mrc-ide.myjetbrains.com/youtrack/issue/bacpop-141

The github actions are running against the "in.development" config, which uses various values from vault - but they don't ever actually attempt to get those values from the vault (using the decrypt_config script).. and I'm not sure we can use the vault in gha anyway? Hence using the hardcoded fake encrypt key (which is integration tested in the gha workflow).. but I think that means we've probably got some vault values which never actually get used as they aren't the "PROD" ones, e.g. GOOGLE_ID, GOOGLE_SECRET (and must not actually get used in any of the integration tests).

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (681489b) 98.91% compared to head (58a10d1) 98.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   98.91%   98.93%   +0.01%     
==========================================
  Files          31       31              
  Lines         648      657       +9     
  Branches      105      107       +2     
==========================================
+ Hits          641      650       +9     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EmmaLRussell EmmaLRussell marked this pull request as ready for review October 5, 2023 08:23
@EmmaLRussell EmmaLRussell requested a review from richfitz October 5, 2023 08:23
@EmmaLRussell
Copy link
Collaborator Author

Closing as we'll implement in front end instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants