-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bacpop-110 Persist Microreact tokens #41
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 98.91% 98.93% +0.01%
==========================================
Files 31 31
Lines 648 657 +9
Branches 105 107 +2
==========================================
+ Hits 641 650 +9
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Closing as we'll implement in front end instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch persists microreact token when user enters one, sending it to the back end to be saved in the redis db, encrypted using the
crypto
package.When the user logs in, any token is fetched, and this will be used next time they generate a Microreact url, rather than requiring them to re-enter their token after each log in.
This means the user doesn't currently have any way to delete or change their token - this will be done in a separate ticket: https://mrc-ide.myjetbrains.com/youtrack/issue/bacpop-141
The github actions are running against the "in.development" config, which uses various values from vault - but they don't ever actually attempt to get those values from the vault (using the
decrypt_config
script).. and I'm not sure we can use the vault in gha anyway? Hence using the hardcoded fake encrypt key (which is integration tested in the gha workflow).. but I think that means we've probably got some vault values which never actually get used as they aren't the "PROD" ones, e.g.GOOGLE_ID
,GOOGLE_SECRET
(and must not actually get used in any of the integration tests).