Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bacpop 186 v9 db #84

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Bacpop 186 v9 db #84

wants to merge 16 commits into from

Conversation

absternator
Copy link
Contributor

@absternator absternator commented Nov 21, 2024

The only change required is to update the keys the cytoscape graph points to, as these have changed due to using another library to manage the graphmls.

Testing:
This branch and associated beebop_py branch is deployed to beebop-dev

Note: tests failing due to network failing on refs db. working with nick to get fixed.

Note: need to wait for beebop_py to merge first before this merge.

image

@absternator absternator marked this pull request as draft November 21, 2024 15:06
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (1c753a7) to head (7a032bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          34       34           
  Lines        2060     2064    +4     
  Branches      270      271    +1     
=======================================
+ Hits         2036     2040    +4     
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@absternator absternator marked this pull request as ready for review December 16, 2024 09:28
@absternator
Copy link
Contributor Author

DO NOT MERGE until beebop_py merged... ALSO revert branch to main after

Copy link
Collaborator

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As discussed, it's odd to have to change the graph keys, but since we're the only ones using the subgraphs it shouldn't affect the full graphml files that people might already be using.

@@ -2,6 +2,6 @@
module.exports = {
preset: 'ts-jest',
testEnvironment: 'node',
testTimeout: 120000,
testTimeout: 240000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dear 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was a test haha good catch I've reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants