Cache Beebop databases in CI #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 34 34
Lines 2060 2060
Branches 270 270
=======================================
Hits 2036 2036
Misses 24 24 ☔ View full report in Codecov by Sentry. |
EmmaLRussell
reviewed
Dec 9, 2024
README.md
Outdated
| @@ -77,6 +77,8 @@ You can also run everything outside pm2, by separately running: | |||
| - `./scripts/run_server` | |||
| - `./scripts/run_client` | |||
|
|
|||
| *Note: If you wish to override the volune with a custom bind mount pass in -mount {MOUNT_NAME} into `run_test` script* | |||
There was a problem hiding this comment.
Suggested change
| *Note: If you wish to override the volune with a custom bind mount pass in -mount {MOUNT_NAME} into `run_test` script* | |
| *Note: If you wish to override the storage volume with a custom bind mount pass in -mount {MOUNT_NAME} into `run_test` script* |
scripts/run_dependencies
Outdated
Comment on lines
8
to
18
| while [ $# -gt 0 ]; do | ||
| case "$1" in | ||
| -mount) | ||
| MOUNT="$2" | ||
| shift 2 | ||
| ;; | ||
| *) | ||
| shift | ||
| ;; | ||
| esac | ||
| done |
There was a problem hiding this comment.
this is shared logic with run _test to find the mount arg - could pull this out into a shared script - or just use a positional arg if it's easier! But it's quite nice and clear to have a named arg.
Yup exactly 😄 |
EmmaLRussell
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does work to allow caching of the beebop databases. The playwright CI and jest integration CI both require pulling databases which can take a long time. These don't change thus we are now caching, so every subsequent run we don't have to redownload databases.
To allow caching having added
mountcli option torun_teststhat allows to mount GHA directory into the/storagefolder (where dbs are downloaded)Testing: can re-run pipeline jest CI / unit_and_integration_backend (20.x) (pull_request) and you will see in logs of _run all components _ step that Database already exists for the multiple databases