warning: unused `std::result::Result` that must be used --> src/multisketch.rs:210:9 | 210 | self.save_metadata(output_file_name); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled help: use `let _ = ...` to ignore the resulting value | 210 | let _ = self.save_metadata(output_file_name); | +++++++

warning: unused `std::result::Result` that must be used --> src/lib.rs:509:13 | 509 | sketches.remove_metadata(ref_db, output_file, &ids); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 509 | let _ = sketches.remove_metadata(ref_db, output_file, &ids); | +++++++

warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` --> src/lib.rs:500:51 | 500 | let ids: Vec<String> = reader.lines().filter_map(|line| line.ok()).collect(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` | note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error --> src/lib.rs:500:36 | 500 | let ids: Vec<String> = reader.lines().filter_map(|line| line.ok()).collect(); | ^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok = note: `#[warn(clippy::lines_filter_map_ok)]` on by default

warning: the borrowed expression implements the required traits --> src/lib.rs:496:35 | 496 | let file = File::open(&path)?; | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:214:1 | 214 | / impl PartialOrd for SparseCoreAcc { 215 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 216 | || self.1.partial_cmp(&other.1) 217 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 218 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl

warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:188:1 | 188 | / impl PartialOrd for SparseJaccard { 189 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 190 | || other.1.partial_cmp(&self.1) // NB: backwards 191 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 192 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

warning: this function has too many arguments (9/7) --> src/sketch.rs:217:1 | 217 | / pub fn sketch_files( 218 | | output_prefix: &str, 219 | | input_files: &[InputFastx], 220 | | concat_fasta: bool, ... | 226 | | min_qual: u8, 227 | | ) -> Vec<Sketch> { | |________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read --> src/sketch_datafile.rs:11:5 | 10 | pub struct SketchArrayFile { | --------------- fields in this struct 11 | bin_stride: usize, | ^^^^^^^^^^ 12 | kmer_stride: usize, | ^^^^^^^^^^^ 13 | sample_stride: usize, | ^^^^^^^^^^^^^ | = note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused variable: `input_prefix` --> src/multisketch.rs:196:9 | 196 | input_prefix: &str, | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_input_prefix` | = note: `#[warn(unused_variables)]` on by default

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/