clean up code #2
johannaheleneAnnotations
1 error and 10 warnings
|
build
Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/distances.rs#L214
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/distances.rs:214:1
|
214 | / impl PartialOrd for SparseCoreAcc {
215 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
216 | || self.1.partial_cmp(&other.1)
217 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
218 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
|
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
src/distances.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> src/distances.rs:188:1
|
188 | / impl PartialOrd for SparseJaccard {
189 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
190 | || other.1.partial_cmp(&self.1) // NB: backwards
191 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
192 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
this function has too many arguments (9/7):
src/sketch.rs#L217
warning: this function has too many arguments (9/7)
--> src/sketch.rs:217:1
|
217 | / pub fn sketch_files(
218 | | output_prefix: &str,
219 | | input_files: &[InputFastx],
220 | | concat_fasta: bool,
... |
226 | | min_qual: u8,
227 | | ) -> Vec<Sketch> {
| |________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read:
src/sketch_datafile.rs#L11
warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read
--> src/sketch_datafile.rs:11:5
|
10 | pub struct SketchArrayFile {
| --------------- fields in this struct
11 | bin_stride: usize,
| ^^^^^^^^^^
12 | kmer_stride: usize,
| ^^^^^^^^^^^
13 | sample_stride: usize,
| ^^^^^^^^^^^^^
|
= note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|