Skip to content

Merge pull request #25 from vrbouza/3di_victordev #20

Merge pull request #25 from vrbouza/3di_victordev

Merge pull request #25 from vrbouza/3di_victordev #20

Triggered via push September 13, 2024 08:17
Status Success
Total duration 1m 48s
Artifacts

ci.yml

on: push
Matrix: Rust project - latest
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
non-canonical implementation of `partial_cmp` on an `Ord` type: src/distances.rs#L214
warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:214:1 | 214 | / impl PartialOrd for SparseCoreAcc { 215 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 216 | || self.1.partial_cmp(&other.1) 217 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 218 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
non-canonical implementation of `partial_cmp` on an `Ord` type: src/distances.rs#L188
warning: non-canonical implementation of `partial_cmp` on an `Ord` type --> src/distances.rs:188:1 | 188 | / impl PartialOrd for SparseJaccard { 189 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> { | | _____________________________________________________________- 190 | || other.1.partial_cmp(&self.1) // NB: backwards 191 | || } | ||_____- help: change this to: `{ Some(self.cmp(other)) }` 192 | | } | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
this function has too many arguments (10/7): src/sketch.rs#L207
warning: this function has too many arguments (10/7) --> src/sketch.rs:207:1 | 207 | / pub fn sketch_files( 208 | | output_prefix: &str, 209 | | input_files: &[InputFastx], 210 | | concat_fasta: bool, ... | 218 | | min_qual: u8, 219 | | ) -> Vec<Sketch> { | |________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read: src/sketch_datafile.rs#L11
warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read --> src/sketch_datafile.rs:11:5 | 10 | pub struct SketchArrayFile { | --------------- fields in this struct 11 | bin_stride: usize, | ^^^^^^^^^^ 12 | kmer_stride: usize, | ^^^^^^^^^^^ 13 | sample_stride: usize, | ^^^^^^^^^^^^^ | = note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused variable: `ids`: src/multisketch.rs#L150
warning: unused variable: `ids` --> src/multisketch.rs:150:35 | 150 | pub fn remove_sketches(&self, ids: &[String]) { | ^^^ help: if this is intentional, prefix it with an underscore: `_ids` | = note: `#[warn(unused_variables)]` on by default
Rust project - latest (nightly)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust project - latest (beta)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust project - latest (stable)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/