Feat/subnet sync #37
Merged
Feat/subnet sync #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppolewicz
reviewed
Sep 26, 2024
Comment on lines
+13
to
+16
| migrations.RemoveField( | ||
| model_name="uploadedfile", | ||
| name="user", | ||
| ), |
There was a problem hiding this comment.
this was merged with another PR
|
|
||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("core", "0005_alter_validatorinstance_server_and_more"), |
There was a problem hiding this comment.
this probably needs adjustment
Comment on lines
59
to
66
| def send_messages(subnet, subnet_identifier): | ||
| """ | ||
| This function sends messages to subnet operators. | ||
| Args: subnet: Subnet object | ||
| subnet_identifier: SubnetID | ||
| """ | ||
| # send message to subnet operators | ||
| pass |
There was a problem hiding this comment.
this was implemented in another PR already
| from auto_validator.core.utils.utils import get_subnet_by_hotkey, get_user_ip, send_messages | ||
|
|
||
|
|
||
| def verify_signature_and_route_subnet(view_func): |
There was a problem hiding this comment.
I think we might already have it but we may be missing some parameter here
|
|
||
| V1_FILES_URL = "/api/v1/files/" | ||
|
|
||
|
|
||
| def test_file_upload(api_client, user, eq): | ||
| @pytest.mark.django_db | ||
| def test_file_upload_with_valid_signature(api_client, wallet, validator_instance): |
| def wallet(): | ||
| coldkey_name = "auto-validator7" | ||
| hotkey_name = "testhotkey7" | ||
| command1 = f"btcli wallet new_coldkey --wallet.name {coldkey_name}" |
There was a problem hiding this comment.
it'd be better to call proper functions from bittensor, but if it aint broken, don't fix it
ppolewicz
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added subnet synchronization with side-by-side comparison