This repository has been archived by the owner on May 28, 2019. It is now read-only.
fix bug about getting list of no BROC module and add retry #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +75,7 @@ def load(self): | |||
| self._git_repo_domain = conf.get('repo', 'git_repo_domain') | |||
| self._svn_postfix_branch = conf.get('repo', 'svn_postfix_branch') | |||
| self._svn_postfix_tag = conf.get('repo', 'svn_postfix_tag') | |||
| self._retry_time = conf.get('repo', 'retry_time') | |||
There was a problem hiding this comment.
在client/broc下已经转换成int了
There was a problem hiding this comment.
前面是整型，此处是字符串，不一致，建议使用conf.getint()
| @@ -33,15 +33,18 @@ def __init__(self): | |||
| self._git_repo_domain = 'https://github.com' | |||
| self._svn_postfix_branch = "BRANCH" | |||
| self._svn_postfix_tag = "PD_BL" | |||
| self._retry_time = 3 | |||
There was a problem hiding this comment.
此处默认的是整型，下面获取到的值又是字符串，前后不一致
added 2 commits
January 13, 2016 13:24
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4 and add retry