Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce rest params and included record params to the json model #482

Merged
merged 26 commits into from
Nov 9, 2024
Merged

Introduce rest params and included record params to the json model #482

merged 26 commits into from
Nov 9, 2024

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

@LakshanWeerasinghe
Index included record params and rest params
26013bd
@LakshanWeerasinghe
Get the infering type correctly
2380658
@LakshanWeerasinghe
Generate default values for included record params
703241f
@LakshanWeerasinghe
Add default value gen util
cee306b
@LakshanWeerasinghe
Remove old DefaultValueGen Util useages
b643ae9
@LakshanWeerasinghe
Refactor code
21f747d
@LakshanWeerasinghe
Update FunctionResult retrival funcs
1edfce3
@LakshanWeerasinghe
Re-generate the index
6075893
@LakshanWeerasinghe
Update function calling templates
b53244a
@LakshanWeerasinghe
Update node template tests
98bc3d0
@LakshanWeerasinghe
Add source builder for function calls
c9c70eb
@LakshanWeerasinghe
Function call to source impl
eaff156
@LakshanWeerasinghe
Update source gen tests
c9786f4
@LakshanWeerasinghe
Fix failing model generator tests
0b640d0
@LakshanWeerasinghe
Update new connection related tests
397ddae
@LakshanWeerasinghe
Model gen for function call args
c8c628d
@LakshanWeerasinghe
Update model generator tests
6d7634f
@LakshanWeerasinghe
Fix build failures
3c820c7
@LakshanWeerasinghe
Re-generate the index
ac81835
@LakshanWeerasinghe
Failing model gen tests
92c38e6
@LakshanWeerasinghe
Update property kinds
6960eca
@LakshanWeerasinghe
Fix failing source gen tests
f71be76
@LakshanWeerasinghe
Update node template tests
26c6455
nipunayf
nipunayf approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@nipunayf nipunayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address the review changes in a separate PR

@nipunayf nipunayf merged commit 95bacde into ballerina-platform:flow_model Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipunayf nipunayf nipunayf approved these changes

@madushajg madushajg Awaiting requested review from madushajg madushajg is a code owner

@sachiniSam sachiniSam Awaiting requested review from sachiniSam sachiniSam is a code owner

@keizer619 keizer619 Awaiting requested review from keizer619 keizer619 is a code owner

@azinneera azinneera Awaiting requested review from azinneera azinneera is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshanWeerasinghe @nipunayf