Merge pull request #5342 from ThisaruGuruge/master

Fix GraphQL BBE issues

examples/graphql-dataloader/graphql_dataloader.bal

@@ -39,7 +39,7 @@ final readonly & table<BookRow> key(id) bookTable = table [
 // of this function is an array of results in which each element in the result array corresponds
 // to a primary key from the `ids` array.
 isolated function bookLoaderFunction(readonly & anydata[] ids) returns BookRow[][]|error {
-    final readonly & int[] keys = check ids.ensureType();
+    final int[] keys = check ids.ensureType();
     log:printInfo("executing bookLoaderFunction", keys = keys);
     // Implement the batching logic.
     return keys.'map(isolated function(readonly & int key) returns BookRow[] {

examples/graphql-documentation/graphql_documentation.bal

@@ -1,6 +1,6 @@
 import ballerina/graphql;
 
-// All the types that are used in the GraphQL service can have doc comments to add as documentation.
+// All the types that are used in the GraphQL service can have documentation.
 # Represents a profile.
 # + name - The name of the profile
 # + age - The age of the profile
@@ -11,7 +11,7 @@ type Profile record {|
 
 service /graphql on new graphql:Listener(9090) {
 
-    // Add doc comments to reflect them in the generated GraphQL schema.
+    // Add documentation to reflect them in the generated GraphQL schema.
     # Returns a profile using the provided ID.
     # + id - The ID of the profile
     # + return - The profile with the requested ID

examples/graphql-documentation/graphql_documentation.md

@@ -1,6 +1,6 @@
 # GraphQL service - Documentation
 
-The Ballerina `graphql` module allows adding documentation to the `graphql:Service` and its subsequent types. To add documentation, use the Ballerina doc comments for the `graphql:Service`, `resource`/`remote` methods, types, and `enum`s. Add the documentation to include the descriptions to the generated GraphQL schema.
+The Ballerina `graphql` module allows adding documentation to the generated GraphQL schema and its subsequent types. To add documentation, use the Ballerina documentation for the `graphql:Service`, `resource`/`remote` methods, types, and `enum`s. The Ballerina documentation will be automatically added as the documentation in the generated GraphQL schema.
 
 ::: code graphql_documentation.bal :::
 

examples/graphql-service-interceptors/graphql_service_interceptors.bal

@@ -19,7 +19,7 @@ readonly service class LogInterceptor {
         log:printInfo(string `Field "${fieldName}" execution started!`);
 
         // The `context.resolve()` function can be used to invoke the next interceptor. If all the
-        // interceptors were executed, and it invokes the actual resolver function. The function
+        // interceptors were executed, then it invokes the actual resolver function. The function
         // returns an `anydata` type value that includes the execution result of the next
         // interceptor or the actual resolver. To call the `context.resolve()` function, the
         // `graphql:Field` value should be provided as the argument.

examples/graphql-subscriptions/graphql_subscriptions.bal

@@ -1,13 +1,9 @@
 import ballerina/graphql;
+import ballerina/lang.runtime;
+import ballerina/random;
 
 service /graphql on new graphql:Listener(9090) {
-    // Defines a `string` array in the service.
-    private string[] names;
-
-    function init() {
-        // Initialize the array.
-        self.names = ["Walter White", "Jesse Pinkman", "Skyler White"];
-    }
+    private final readonly & string[] names = ["Walter White", "Jesse Pinkman", "Saul Goodman"];
 
     resource function get names() returns string[] {
         return self.names;
@@ -16,7 +12,29 @@ service /graphql on new graphql:Listener(9090) {
     // A resource method with the `subscribe` accessor represents a field in the root
     // `Subscription` operation. It must always return a stream. Since the stream is of type
     // `string`, the resulting field in the generated GraphQL schema will be of type `String!`.
-    resource function subscribe names() returns stream<string> {
-        return self.names.toStream();
+    resource function subscribe names() returns stream<string, error?> {
+        // Create a `NameGenerator` object.
+        NameGenerator nameGenerator = new (self.names);
+        // Create a stream using the `NameGenerator` object.
+        stream<string, error?> names = new (nameGenerator);
+        return names;
+    }
+}
+
+// Defines a stream implementor that can be used to create a stream of strings. This will pick a random name from
+// the list of names and return it with a delay to demonstrate a stream of values.
+class NameGenerator {
+    private final string[] names;
+
+    isolated function init(string[] names) {
+        self.names = names;
+    }
+
+   // The `next` method picks a random name from the list and returns it.
+    public isolated function next() returns record {|string value;|}|error? {
+        // Sleep for 1 second to simulate a delay.
+        runtime:sleep(1);
+        int index = check random:createIntInRange(0, self.names.length());
+        return {value: self.names[index]};
     }
 }