Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BBEs related to the data.yaml module #5531

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Add BBEs related to the data.yaml module #5531

merged 11 commits into from
Aug 21, 2024

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

This BBEs are related to the data.yaml module implementation.

MaryamZi
MaryamZi reviewed Aug 5, 2024
View reviewed changes
examples/anydata-to-yaml-string/anydata_to_yaml_string.md Outdated Show resolved Hide resolved
examples/anydata-to-yaml-string/anydata_to_yaml_string.bal Outdated Show resolved Hide resolved
examples/anydata-to-yaml-string/anydata_to_yaml_string.bal Outdated Show resolved Hide resolved
examples/index.json Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.bal Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.bal Outdated Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.bal Outdated Show resolved Hide resolved
@LakshanWeerasinghe LakshanWeerasinghe changed the base branch from master to 2201.10.x August 6, 2024 04:16
@LakshanWeerasinghe LakshanWeerasinghe changed the base branch from 2201.10.x to master August 6, 2024 04:16
MaryamZi
MaryamZi reviewed Aug 7, 2024
View reviewed changes
examples/anydata-to-yaml-string/any_data_to_yaml_string.metatags Outdated Show resolved Hide resolved
examples/anydata-to-yaml-string/anydata_to_yaml_string.md Outdated Show resolved Hide resolved
examples/index.json
@@ -4619,6 +4619,34 @@
}
]
},
{
"title": "YAML data",
"column": 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This column may be too long now.

Also see https://github.com/ballerina-platform/ballerina-distribution/issues/5537

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to fix others, but can we at least make sure this is added okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the Table to column 2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that this was being added under common libraries. If so, the table change isn't relevant?

Btw we have xmldata and jsondata examples under Language concepts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping on this.

examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.bal Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.bal Outdated Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.md Outdated Show resolved Hide resolved
MaryamZi
MaryamZi reviewed Aug 7, 2024
View reviewed changes
examples/anydata-to-yaml-string/any_data_to_yaml_string.metatags Outdated Show resolved Hide resolved
examples/anydata-to-yaml-string/any_data_to_yaml_string.metatags Outdated Show resolved Hide resolved
examples/anydata-to-yaml-string/anydata_to_yaml_string.md Outdated Show resolved Hide resolved
examples/index.json
@@ -4619,6 +4619,34 @@
}
]
},
{
"title": "YAML data",
"column": 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that this was being added under common libraries. If so, the table change isn't relevant?

Btw we have xmldata and jsondata examples under Language concepts.

examples/index.json Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.md Outdated Show resolved Hide resolved
@LakshanWeerasinghe LakshanWeerasinghe changed the title Add BBEs related to the data.yaml moduel Add BBEs related to the data.yaml module Aug 12, 2024
MaryamZi
MaryamZi reviewed Aug 21, 2024
View reviewed changes
examples/index.json Outdated
@@ -4614,11 +4614,39 @@
"name": "Record to XML conversion",
"url": "xml-from-record-conversion",
"verifyBuild": true,
"verifyOutput": true,
"verifyOutput": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was failing due to its output cannot be verified. So decided to make it false.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we fixing output verification instead? Isn't the issue that the new xmldata version isn't updated in the distribution? Let's undo this change and send a separate PR for that (or get the library owner/RM to look into it) first.

examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.bal Outdated Show resolved Hide resolved
examples/yaml-to-anydata/yaml_to_anydata.metatags Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LakshanWeerasinghe LakshanWeerasinghe added this pull request to the merge queue Aug 21, 2024
Merged via the queue into ballerina-platform:master with commit 189afcc Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamZi MaryamZi MaryamZi approved these changes

@hevayo hevayo Awaiting requested review from hevayo

@keizer619 keizer619 Awaiting requested review from keizer619 keizer619 is a code owner

Assignees
No one assigned
Labels
Area/BBE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshanWeerasinghe @MaryamZi