Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ballerina By Examples to include references to the binary data BBE links #5632

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Update Ballerina By Examples to include references to the binary data BBE links #5632

merged 5 commits into from
Sep 19, 2024

Conversation

SasinduDilshara
Copy link
Contributor

@SasinduDilshara SasinduDilshara commented Sep 10, 2024 •
edited
Loading

Update Ballerina By Examples to include references to the binary data and list equality BBE links

Fixes ballerina-platform/ballerina-dev-website#9385

@SasinduDilshara SasinduDilshara changed the title Update Ballerina By Examples to include references to the binary data and list equality BBE links Update Ballerina By Examples to include references to the binary data and list equality BBE links Sep 10, 2024
sm1990
sm1990 previously approved these changes Sep 10, 2024
View reviewed changes
@rdulmina
Copy link
Contributor

We need to address
https://github.com/rdulmina/ballerina-distribution/blob/0b2a4eda9c2043126184540d1e3cd6eaf705246d/examples/binary-data/binary_data.md?plain=1#L13

@SasinduDilshara
Copy link
Contributor Author

We need to address https://github.com/rdulmina/ballerina-distribution/blob/0b2a4eda9c2043126184540d1e3cd6eaf705246d/examples/binary-data/binary_data.md?plain=1#L13

We can address this comment after adding a BBE for byte type.
I will be a separate task

sm1990
sm1990 previously approved these changes Sep 11, 2024
View reviewed changes
MaryamZi
MaryamZi reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title mentions list equality, but it's not linked?

examples/http-service-file-upload/http_service_file_upload.md Outdated Show resolved Hide resolved
examples/yaml-to-anydata-with-projection/yaml_to_anydata_with_projection.md Outdated Show resolved Hide resolved
@MaryamZi
Copy link
Member

The title mentions list equality, but it's not linked?

Ping on this.

@SasinduDilshara
Copy link
Contributor Author

SasinduDilshara commented Sep 18, 2024 •
edited
Loading

The title mentions list equality, but it's not linked?

Updated

@SasinduDilshara SasinduDilshara changed the title Update Ballerina By Examples to include references to the binary data and list equality BBE links Update Ballerina By Examples to include references to the binary data BBE links Sep 18, 2024
@SasinduDilshara SasinduDilshara mentioned this pull request Sep 18, 2024
Merged
sm1990
sm1990 previously approved these changes Sep 18, 2024
View reviewed changes
MaryamZi
MaryamZi previously approved these changes Sep 19, 2024
View reviewed changes
MaryamZi
MaryamZi reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the change https://github.com/ballerina-platform/ballerina-distribution/pull/5656/files#diff-08d375d409a03fb8f4e8e4393c3bcdff402cf831aff074d8a2fda0ebceacaa67R16 not here?

NipunaRanasinghe
NipunaRanasinghe reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SasinduDilshara FYA #5656 (review)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SasinduDilshara
Copy link
Contributor Author

Why is the change https://github.com/ballerina-platform/ballerina-distribution/pull/5656/files#diff-08d375d409a03fb8f4e8e4393c3bcdff402cf831aff074d8a2fda0ebceacaa67R16 not here?

updated

1 similar comment
@SasinduDilshara
Copy link
Contributor Author

Why is the change https://github.com/ballerina-platform/ballerina-distribution/pull/5656/files#diff-08d375d409a03fb8f4e8e4393c3bcdff402cf831aff074d8a2fda0ebceacaa67R16 not here?

updated

NipunaRanasinghe
NipunaRanasinghe approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryamZi MaryamZi added this pull request to the merge queue Sep 19, 2024
Merged via the queue into ballerina-platform:master with commit 98fbd0a Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryamZi MaryamZi MaryamZi approved these changes

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe approved these changes

@sm1990 sm1990 sm1990 left review comments

@hevayo hevayo Awaiting requested review from hevayo

@keizer619 keizer619 Awaiting requested review from keizer619

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

@daneshk daneshk Awaiting requested review from daneshk

@rdulmina rdulmina Awaiting requested review from rdulmina

@TharmiganK TharmiganK Awaiting requested review from TharmiganK

Assignees
No one assigned
Labels
Area/BBE Team/CompilerFE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Binary data BBE as reference for related BBEs
5 participants
@SasinduDilshara @rdulmina @MaryamZi @sm1990 @NipunaRanasinghe