Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BBE for byte and expression equality #5634

Merged
merged 12 commits into from
Sep 19, 2024
Merged

Add BBE for byte and expression equality #5634

merged 12 commits into from
Sep 19, 2024

Conversation

SasinduDilshara
Copy link
Contributor

@gimantha gimantha changed the base branch from master to 2201.0.x September 13, 2024 04:33
@gimantha gimantha changed the base branch from 2201.0.x to master September 13, 2024 04:33
MaryamZi
MaryamZi reviewed Sep 18, 2024
View reviewed changes
examples/byte-type/byte_type.bal Outdated Show resolved Hide resolved
examples/byte-type/byte_type.bal Outdated Show resolved Hide resolved
examples/byte-type/byte_type.metatags Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.md Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.md Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.bal Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.bal Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.bal Outdated Show resolved Hide resolved
examples/expression-equality/expression_equality.bal Outdated Show resolved Hide resolved
@SasinduDilshara SasinduDilshara mentioned this pull request Sep 18, 2024
Merged
MaryamZi
MaryamZi reviewed Sep 19, 2024
View reviewed changes
examples/index.json Outdated Show resolved Hide resolved
MaryamZi
MaryamZi previously approved these changes Sep 19, 2024
View reviewed changes
gimantha
gimantha reviewed Sep 19, 2024
View reviewed changes
examples/byte-type/byte_type.metatags Outdated
@@ -0,0 +1,2 @@
description: This BBE introduces the Ballerina byte type.
keywords: ballerina, ballerina by example, bbe, bytes, byte, byte type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add unsigned8 also? @SasinduDilshara @MaryamZi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we may need to refer to https://ballerina.io/learn/by-example/built-in-integer-subtypes/ as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gimantha gimantha added this pull request to the merge queue Sep 19, 2024
Merged via the queue into ballerina-platform:master with commit c833334 Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NipunaRanasinghe NipunaRanasinghe NipunaRanasinghe left review comments

@heshanpadmasiri heshanpadmasiri heshanpadmasiri left review comments

@gimantha gimantha gimantha approved these changes

@MaryamZi MaryamZi MaryamZi approved these changes

@hevayo hevayo Awaiting requested review from hevayo

@keizer619 keizer619 Awaiting requested review from keizer619

@LakshanWeerasinghe LakshanWeerasinghe Awaiting requested review from LakshanWeerasinghe

Assignees
No one assigned
Labels
Area/BBE Team/CompilerFE
Projects
None yet
Milestone
No milestone
6 participants
@SasinduDilshara @MaryamZi @gimantha @heshanpadmasiri @NipunaRanasinghe @LakshanWeerasinghe