Update raw-template BBE to remove external dependency #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshanpadmasiri
requested review from
MaryamZi,
NipunaRanasinghe and
gimantha
as code owners
heshanpadmasiri
force-pushed
the
feat/raw-template
branch
from
7300922
to
f98ab1c
Compare
MaryamZi
reviewed
Oct 21, 2024
heshanpadmasiri
force-pushed
the
feat/raw-template
branch
from
0f2d410
to
eed8348
Compare
heshanpadmasiri
commented
Oct 21, 2024
| VALUES (2, 1, 15)`); | ||
| type MyCSVRawTemplate object { | ||
| *object:RawTemplate; | ||
| public (string[] & readonly) strings; |
There was a problem hiding this comment.
this field is needed due to ballerina-platform/ballerina-lang#43501
heshanpadmasiri
force-pushed
the
feat/raw-template
branch
from
eed8348
to
1e62858
Compare
MaryamZi
reviewed
Oct 21, 2024
MaryamZi
reviewed
Oct 28, 2024
Co-authored-by: Maryam Ziyad <maryamziyadm@gmail.com>
heshanpadmasiri
force-pushed
the
feat/raw-template
branch
from
b39af2b
to
451fb42
Compare
MaryamZi
reviewed
Oct 29, 2024
Co-authored-by: Maryam Ziyad <maryamziyadm@gmail.com>
MaryamZi
reviewed
Oct 29, 2024
Co-authored-by: Maryam Ziyad <maryamziyadm@gmail.com>
MaryamZi
reviewed
Oct 30, 2024
Co-authored-by: Maryam Ziyad <maryamziyadm@gmail.com>
|
MaryamZi
approved these changes
Oct 30, 2024
Merged
via the queue into
ballerina-platform:master
with commit Oct 30, 2024
4354864
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Resolves ballerina-platform/ballerina-dev-website#9323