Commits on Nov 13, 2024

1. Avoid BUnionType's getMemberTypes() usages part 1

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6e0645f
   • Browse repository at this point

   Copy the full SHA

   6e0645f View commit details

   Browse the repository at this point in the history

2. Rewrite isLaxType() check using semtypes

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 3916457
   • Browse repository at this point

   Copy the full SHA

   3916457 View commit details

   Browse the repository at this point in the history

3. Avoid BUnionType's getMemberTypes() usages part 2

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 4ba7f21
   • Browse repository at this point

   Copy the full SHA

   4ba7f21 View commit details

   Browse the repository at this point in the history

4. Avoid BUnionType's getMemberTypes() usages part 3

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for bb6332c
   • Browse repository at this point

   Copy the full SHA

   bb6332c View commit details

   Browse the repository at this point in the history

5. Get rid of old BSameTypeVisitor part 1

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ae53230
   • Browse repository at this point

   Copy the full SHA

   ae53230 View commit details

   Browse the repository at this point in the history

6. Get rid of old BSameTypeVisitor part 2

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f952608
   • Browse repository at this point

   Copy the full SHA

   f952608 View commit details

   Browse the repository at this point in the history

7. Get rid of BIRSameShapeVisitor …

   Since ballerina-platform#35886 has been addressed, we should be able to remove the temporary shape check workaround.
   Please refer to ballerina-platform#35872 (comment)

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for aca8f5a
   • Browse repository at this point

   Copy the full SHA

   aca8f5a View commit details

   Browse the repository at this point in the history

8. Get rid of BSameTypeVisitor part 3

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 562e9f6
   • Browse repository at this point

   Copy the full SHA

   562e9f6 View commit details

   Browse the repository at this point in the history

9. Get rid of BOrderedTypeVisitor

   

   lochana-chathura committed Nov 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 46b4355
   • Browse repository at this point

   Copy the full SHA

   46b4355 View commit details

   Browse the repository at this point in the history

10. Refactor calls to semType

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 351c09f
    • Browse repository at this point

    Copy the full SHA

    351c09f View commit details

    Browse the repository at this point in the history

11. Fix spotbugs issues

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 366ae2c
    • Browse repository at this point

    Copy the full SHA

    366ae2c View commit details

    Browse the repository at this point in the history

12. Rewrite JvmTypeTestGen, JvmTerminatorGen getMemberTypes calls

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for fc00fca
    • Browse repository at this point

    Copy the full SHA

    fc00fca View commit details

    Browse the repository at this point in the history

13. Fix wrong interop error msg for error included return types …

    Previously ballerina `readonly` return type allowed for java void methods. However, `error?` was not allowed with java void. This inconsistency is due to type checking not recognizing the fact that readonly type does include the error type. The error given in the latter case too is wrong because error is optional.

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 1a00fe5
    • Browse repository at this point

    Copy the full SHA

    1a00fe5 View commit details

    Browse the repository at this point in the history

14. Implement isAssignableIgnoreObjectTypeIds() properly …

    Previously this was implemented with a temporary workaround which was inefficient as we recalculated the semtypes.

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 9404493
    • Browse repository at this point

    Copy the full SHA

    9404493 View commit details

    Browse the repository at this point in the history

15. Fix :semtypes:javadoc failure

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for deddfab
    • Browse repository at this point

    Copy the full SHA

    deddfab View commit details

    Browse the repository at this point in the history

16. Simplify equality-expr operand intersection check using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 99bcfdf
    • Browse repository at this point

    Copy the full SHA

    99bcfdf View commit details

    Browse the repository at this point in the history

17. Fix EscapedIdentifiersValidationTest failure due to BType mutation

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for cb06d16
    • Browse repository at this point

    Copy the full SHA

    cb06d16 View commit details

    Browse the repository at this point in the history

18. Refactor code to use semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 02a9afa
    • Browse repository at this point

    Copy the full SHA

    02a9afa View commit details

    Browse the repository at this point in the history

19. Fix testFunctionalProgramming shell test failure …

    Please refer to ballerina-platform#43344 (comment) for the reason

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 7bcd50c
    • Browse repository at this point

    Copy the full SHA

    7bcd50c View commit details

    Browse the repository at this point in the history

20. Rewrite isTypeCastable() using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 41463dd
    • Browse repository at this point

    Copy the full SHA

    41463dd View commit details

    Browse the repository at this point in the history

21. Rewrite intersectionExists() in CodeAnalyzer using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 9b34bb6
    • Browse repository at this point

    Copy the full SHA

    9b34bb6 View commit details

    Browse the repository at this point in the history

22. Rewrite isNumericConversionPossible(), getErrorTypes() using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for e67221a
    • Browse repository at this point

    Copy the full SHA

    e67221a View commit details

    Browse the repository at this point in the history

23. Fix :ballerina-langlib:test:test failure

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 001cdd5
    • Browse repository at this point

    Copy the full SHA

    001cdd5 View commit details

    Browse the repository at this point in the history

24. Refactor code based on the review suggestions

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 244de44
    • Browse repository at this point

    Copy the full SHA

    244de44 View commit details

    Browse the repository at this point in the history

25. Simplify JvmTypeTestGen canOptimizeErrorCheck using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for 445ecc9
    • Browse repository at this point

    Copy the full SHA

    445ecc9 View commit details

    Browse the repository at this point in the history

26. Simplify JvmTypeTestGen canOptimizeNilCheck using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for e2ce145
    • Browse repository at this point

    Copy the full SHA

    e2ce145 View commit details

    Browse the repository at this point in the history

27. Rewrite annot type desc validation using semtypes

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for eac0942
    • Browse repository at this point

    Copy the full SHA

    eac0942 View commit details

    Browse the repository at this point in the history

28. Clean up unused methods in SymbolEnter

    

    lochana-chathura committed Nov 13, 2024
    Configuration menu

    • View commit details
    • Copy full SHA for ff06641
    • Browse repository at this point

    Copy the full SHA

    ff06641 View commit details

    Browse the repository at this point in the history