Fix dead code elimination removing fpLoadInstructions from test modules
#43559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thushara-Piyasekara
requested review from
gimantha,
MaryamZi,
KavinduZoysa,
warunalakshitha,
azinneera,
sameerajayasoma and
hasithaa
as code owners
Thushara-Piyasekara
changed the title
fpLoadInstructions from test modulesfpLoadInstructions from test modules
gimantha
reviewed
Nov 8, 2024
...st/src/test/java/org/ballerinalang/testerina/test/OptimizedTestRunWithEmptyBuildPkgTest.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Nov 8, 2024
...ation-reports/optimized-test-run-with-empty-build-pkg-test/dead_code_elimination_report.json
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Nov 8, 2024
...ources/project-based-tests/optimized-test-run-with-empty-build-pkg-test/tests/tests_test.bal
Outdated
Show resolved
Hide resolved
…timization-reports/optimized-test-run-with-empty-build-pkg-test/dead_code_elimination_report.json
…ng/testerina/test/OptimizedTestRunWithEmptyBuildPkgTest.java
…sed-tests/optimized-test-run-with-empty-build-pkg-test/tests/tests_test.bal
gimantha
merged commit f5a6f0c
into
ballerina-platform:feature-codegen-optimizer
2 checks passed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Fixes #43552
Approach
The reason for the NPE is due to a bug in dead code elimination removing used
fpLoadInstructionsfrom test modules. This was due to implementation depending onpkgId.isTestPkgto detecttestablePkganalysis.The expected behavior should be not removing any nodes from
testablePkgs.Check List