Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Update debugger project loader to support bal persist sources #43578

Conversation

NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe commented Nov 13, 2024

Purpose

$subject to fix intermittent debugger failures on Ballerina projects with Bal persist sources.

Temporarily fixes #43538
Related to https://github.com/wso2-enterprise/internal-support-ballerina/issues/803

Remarks

As per #43538 (comment), a generic approach to address these kind of tooling file specific issues should be addressed from the Ballerina platform side. This is done as a temporary workaround until we get there.

Related issues: #43537

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

azinneera
azinneera previously approved these changes Nov 13, 2024
ayeshLK
ayeshLK previously approved these changes Nov 13, 2024
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (66f7b52) to head (574e734).
Report is 41 commits behind head on master.

Files with missing lines Patch % Lines
...ballerinalang/debugadapter/utils/PackageUtils.java 56.00% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #43578   +/-   ##
=========================================
  Coverage     77.55%   77.56%           
- Complexity    58722    58753   +31     
=========================================
  Files          3447     3448    +1     
  Lines        219658   219732   +74     
  Branches      28915    28923    +8     
=========================================
+ Hits         170365   170425   +60     
- Misses        39892    39909   +17     
+ Partials       9401     9398    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NipunaRanasinghe NipunaRanasinghe merged commit d25f02f into ballerina-platform:master Nov 14, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Intermittent debugger failures on Ballerina projects with Bal persist sources
4 participants