Fix go to definition when server returns LocationLink #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
"Go to definition" completely breaks down when using LSP4IntelliJ for connecting to the Zig Language Server.
The source of this issue was that ZLS returns a
LocationLink
instead of a Location in the reply to thedefinition
call, and this causes lsp4intellij to "spazz out", and open dozens of unrelated editors.Goals
Implement a basic way for interpreting
LocationLink
without affecting too much of the codebase.Approach
LocationLink
contains all of the information necessary to construct aLocation
object, so I just added a trivial conversion to theEditorEventManager.requestDefinition
method.User stories
I have personally experienced this problem while developing a Zig language plugin for intellij using this library.
Once the fix was implemented in a local fork, go to definition started working normally again.
Release note
Added basic compatibility with
LocationLink
responses for definition lookups.