-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSV data module Implementation for Ballerina #4
Conversation
Updated |
native/src/main/java/io/ballerina/lib/data/csvdata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
Refactor APIs and API docs
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/FromString.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/FromString.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/csvdata/utils/CsvUtils.java
Outdated
Show resolved
Hide resolved
Reply to #4 (comment) I think it is better to have |
Where it makes sense, IMO, we can (and should) use the ideal way supported by Ballerina. Some other frameworks may have different types/APIs because it is not possible to do this way. |
Update header parameter to be in nilable type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor nits other than that LGTM
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
compiler-plugin/src/main/java/io/ballerina/lib/data/csvdata/compiler/CsvDataTypeValidator.java
Outdated
Show resolved
Hide resolved
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
native/src/main/java/io/ballerina/lib/data/csvdata/io/DataReaderThreadPool.java
Outdated
Show resolved
Hide resolved
Add a unique thread id for each running threads
Purpose
Fixes: ballerina-platform/ballerina-library#6225
Fixes ballerina-platform/ballerina-library#6874
Following are the public apis for the module