Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load tests for main CSV data module functions #7

Conversation

SasinduDilshara
Copy link
Contributor

@SasinduDilshara SasinduDilshara commented Jul 19, 2024

Add load tests for main CSV data module functions
Fixes ballerina-platform/ballerina-library#6756

@SasinduDilshara
Copy link
Contributor Author

This PR needs to merge after #4

@@ -0,0 +1,28 @@
// Copyright (c) 2021 WSO2 Inc. (http://www.wso2.org) All Rights Reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the licence headers.

org = "ballerina"
name = "data.csv"
version = "0.1.0"
repository="local"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repository="local"
repository="local"

version = "0.0.1"

[build-options]
observabilityIncluded = false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
observabilityIncluded = false

observabilityIncluded = false
cloud = "k8s"

[[dependency]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this dependency from here. When running the load tests, this should always use the latest data.csv version.


import ballerina/io;
import ballerina/http;
import ballerina/data.csv as csv;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import ballerina/data.csv as csv;
import ballerina/data.csv;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reorder the imports


final string data = check io:fileReadString("resources/input.csv");

isolated service http:Service /BalPerformance on new http:Listener(9090) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isolated service http:Service /BalPerformance on new http:Listener(9090) {
isolated service /BalPerformance on new http:Listener(9090) {

@SasinduDilshara
Copy link
Contributor Author

This PR will be merge after #4

Copy link

github-actions bot commented Aug 9, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 9, 2024
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Aug 12, 2024
@SasinduDilshara SasinduDilshara marked this pull request as draft August 19, 2024 16:33
@SasinduDilshara
Copy link
Contributor Author

This PR will draft until #4 get merge

@SasinduDilshara
Copy link
Contributor Author

This PR will be reopen after #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants