Fix review suggestions

ballerina-platform · Sep 20, 2024 · e3855c5 · e3855c5
1 parent f40ab3b
commit e3855c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...erina-tests/http-dispatching-tests/tests/service_dispatching_query_param_binding_test.bal b/...erina-tests/http-dispatching-tests/tests/service_dispatching_query_param_binding_test.bal
@@ -343,11 +343,11 @@ function testMapJsonOfDefaultableQueryBinding() returns error? {
 function testMapJsonArrOfDefaultableQueryBinding() returns error? {
     json response = check queryBindingClient->get("/default/q4");
     common:assertJsonPayloadtoJsonString(response, {
-                                                       objects: [
-                                                           {name: "test1", value: "json1"},
-                                                           {name: "test2", value: "json2"}
-                                                       ]
-                                                   });
+        objects: [
+            {name: "test1", value: "json1"},
+            {name: "test2", value: "json2"}
+        ]
+    });
 }
 
 @test:Config {}

diff --git a/native/src/main/java/io/ballerina/stdlib/http/api/service/signature/ParamHandler.java b/native/src/main/java/io/ballerina/stdlib/http/api/service/signature/ParamHandler.java
@@ -291,7 +291,7 @@ private static String getQueryParamName(String paramName, BMap annotations) {
         BMap mapValue = annotations.getMapValue(StringUtils.fromString(QUERY_ANNOTATION));
         Object queryName = mapValue.get(HttpConstants.ANN_FIELD_NAME);
         if (queryName instanceof BString query) {
-            paramName = query.getValue();
+            return query.getValue();
         }
         return paramName;
     }