New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adding cause to the error logs #1649

Merged

dilanSachi merged 1 commit into ballerina-platform:master from dilanSachi:remove-logs

Jul 20, 2023

Contributor

dilanSachi commented Jun 6, 2023 •

edited

Loading

Purpose

$subject
Related to ballerina-platform/ballerina-library#4501

Examples

Checklist


Remove adding cause to the error logs

4b1478c

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.21 🎉

Comparison is base (954b764) 81.33% compared to head (4b1478c) 81.55%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1649      +/-   ##
============================================
+ Coverage     81.33%   81.55%   +0.21%     
- Complexity        0      559     +559     
============================================
  Files           356      391      +35     
  Lines         19520    21276    +1756     
  Branches       4387     4739     +352     
============================================
+ Hits          15877    17352    +1475     
- Misses         2797     2935     +138     
- Partials        846      989     +143

Impacted Files	Coverage Δ
...rt/contractimpl/listener/HttpExceptionHandler.java	`37.50% <0.00%> (ø)`
...tractimpl/sender/CertificateValidationHandler.java	`61.90% <0.00%> (ø)`
...ntractimpl/common/http2/Http2ExceptionHandler.java	`81.81% <100.00%> (ø)`

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.2% Duplication

github-actions bot commented Jun 22, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions bot added the Stale label

TharmiganK removed the Stale label

github-actions bot commented Jul 8, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions bot added the Stale label

TharmiganK removed the Stale label

TharmiganK approved these changes

View reviewed changes

Contributor

TharmiganK left a comment

LGTM

TharmiganK marked this pull request as ready for review

July 20, 2023 04:26

TharmiganK requested a review from shafreenAnfar as a code owner

July 20, 2023 04:26

dilanSachi merged commit 280d4e8 into ballerina-platform:master

4 checks passed

dilanSachi deleted the remove-logs branch

July 20, 2023 04:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment