Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client-side keep-alive handling logic #1810

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Update client-side keep-alive handling logic #1810

merged 5 commits into from
Nov 17, 2023

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Nov 16, 2023 •
edited
Loading

Purpose

$subject
Fixes ballerina-platform/ballerina-library#5793

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests (already there) (Tested by checking the trace logs as well)
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 16, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8eda7d0) 81.67% compared to head (1d8d78b) 81.70%.
Report is 1 commits behind head on master.

Files Patch % Lines
...tdlib/http/transport/contractimpl/common/Util.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1810      +/-   ##
============================================
+ Coverage     81.67%   81.70%   +0.03%     
  Complexity      562      562              
============================================
  Files           393      393              
  Lines         21343    21352       +9     
  Branches       4780     4783       +3     
============================================
+ Hits          17432    17446      +14     
+ Misses         2926     2918       -8     
- Partials        985      988       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi marked this pull request as ready for review November 16, 2023 09:40
@dilanSachi dilanSachi removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 16, 2023
TharmiganK
TharmiganK previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 17, 2023
@dilanSachi dilanSachi merged commit 6652d1b into ballerina-platform:master Nov 17, 2023
8 of 10 checks passed
@dilanSachi dilanSachi deleted the fix-keep-alive-issue branch November 17, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TharmiganK TharmiganK TharmiganK approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

Assignees
No one assigned
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ballerina HTTP client doesn't honour to server-initiated connection closures
2 participants
@dilanSachi @TharmiganK