[master] Add Query Parameter Annotation Mapping #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnash94
requested review from
TharmiganK,
daneshk and
shafreenAnfar
as code owners
ballerina-tests/http-client-tests/tests/client_resource_method_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-client-tests/tests/client_resource_method_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-client-tests/tests/client_resource_method_tests.bal
Outdated
Show resolved
Hide resolved
ballerina-tests/http-client-tests/tests/client_resource_method_tests.bal
Outdated
Show resolved
Hide resolved
lnash94
force-pushed
the
query_field_annotation_fix
branch
3 times, most recently
from
2d046a3
to
7226b2d
Compare
lnash94
force-pushed
the
query_field_annotation_fix
branch
from
7226b2d
to
504c437
Compare
TharmiganK
reviewed
Sep 10, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
lnash94
force-pushed
the
query_field_annotation_fix
branch
from
b8c850b
to
5016a8b
Compare
TharmiganK
reviewed
Sep 11, 2024
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
…-ballerina-http into query_field_annotation_fix
lnash94
force-pushed
the
query_field_annotation_fix
branch
from
9aebbac
to
c76ae04
Compare
lnash94
force-pushed
the
query_field_annotation_fix
branch
2 times, most recently
from
1218d3d
to
241d462
Compare
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 11, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Show resolved
Hide resolved
lnash94
force-pushed
the
query_field_annotation_fix
branch
from
241d462
to
ef175c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
============================================
+ Coverage 80.21% 80.28% +0.06%
Complexity 669 669
============================================
Files 408 408
Lines 22926 22953 +27
Branches 5271 5276 +5
============================================
+ Hits 18391 18427 +36
+ Misses 3403 3392 -11
- Partials 1132 1134 +2 ☔ View full report in Codecov by Sentry. |
TharmiganK
reviewed
Sep 12, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Sep 12, 2024
native/src/main/java/io/ballerina/stdlib/http/api/client/actions/HttpClientAction.java
Show resolved
Hide resolved
lnash94
force-pushed
the
query_field_annotation_fix
branch
from
99cdb42
to
bb44773
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#6983
Partial fix for the main issue: ballerina-platform/ballerina-library#6747
Examples
Checklist
@http:Queryannotation details into OAS code generation ballerina-library#6984