[master] Use toJson method from data.jsondata module in http client
#2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnash94
changed the title
toJson method from data.jsondata moduletoJson method from data.jsondata module in http client
lnash94
force-pushed
the
integrate-data.json
branch
from
2a45f07
to
9ad1b3b
Compare
|
Checking the feasibility of enabling this implementation because we encounter this issue ballerina-platform/ballerina-library#7008 from jsondata module |
…le-ballerina-http into integrate-data.json
TharmiganK
reviewed
Sep 23, 2024
native/src/main/java/io/ballerina/stdlib/http/api/nativeimpl/ExternResponseProcessor.java
Outdated
Show resolved
Hide resolved
…le-ballerina-http into integrate-data.json # Conflicts: # ballerina-tests/http-client-tests/tests/sc_res_binding_tests.bal
lnash94
force-pushed
the
integrate-data.json
branch
from
4611b5d
to
6566fcb
Compare
lnash94
force-pushed
the
integrate-data.json
branch
from
6566fcb
to
6f4fe95
Compare
|
As per our discussion at the stand up 2024/09/24, this PR will be closed till we receive the fix from data.jsondata module ballerina-platform/ballerina-library#7024 and it is a blocker for the this migration |
|
|
Close this PR and will send once this fix ballerina-platform/ballerina-library#7024 (comment) |
6 tasks
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix: ballerina-platform/ballerina-library#7012
Client data binding integration: ballerina-platform/ballerina-library#6747
Service data binding integration: ballerina-platform/ballerina-library#7011
Disable the below test because of data.json data module currently does not support the
tabletypesand enable tests once this issue is done: ballerina-platform/ballerina-library#7020
Examples
Checklist
Dependent PR : ballerina-platform/module-ballerina-data.jsondata#35 once this is merged , test can be added with new data.jsondata timestamp