Update Test for createObject Function
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharindu-nw
approved these changes
Jul 26, 2024
tharindu-nw
requested changes
Jul 26, 2024
| }; | ||
|
|
||
| Client amazonS3Client = check new(amazonS3Config); | ||
| _ = check amazonS3Client->createObject(testBucketName, fileName, content, userMetadataHeaders = metadata); |
There was a problem hiding this comment.
Shall we test if the metadata was correctly added by getting the object and checking the metadata?
There was a problem hiding this comment.
The getObject function does not retrieve user-defined metadata. I only updated the createObject function to add user-defined metadata. Is there any other way to test it without using the getObject function?
There was a problem hiding this comment.
Can we do something similar to what we did for the doc-ui GET endpoint? Calling the s3 url with range=0 and check the headers of the response?
http:Response|error response = httpClient->get("objectUrl", {"Range": "bytes=0-0"});
There was a problem hiding this comment.
This improvement will be tracked in ballerina-platform/ballerina-library#6989
tharindu-nw
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Related Pull Requests (remove if not relevant)
One line release note:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Security checks