Fix potential HTTP client hanging issues while retrieving XML payloads #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# this is to include the improvements suggested in ballerina-platform/ballerina-library#5714
TharmiganK
reviewed
Sep 2, 2024
| @@ -61,7 +62,11 @@ public isolated client class Client { | |||
| check generateSignature(self.accessKeyId, self.secretAccessKey, self.region, GET, SLASH, UNSIGNED_PAYLOAD, | |||
| requestHeaders); | |||
| http:Response httpResponse = check self.amazonS3->get(SLASH, requestHeaders); | |||
| xml xmlPayload = check httpResponse.getXmlPayload(); | |||
| string stringPayload = check httpResponse.getTextPayload(); | |||
There was a problem hiding this comment.
This is not required here. The hanging issue can occur only when you return the same response object - httpResponse
|
As per the offline discussion with @TharmiganK, we've decided not to ship this fix as per ballerina-platform/ballerina-library#5714 (comment) as this only happens when we send the same |
|
Closing as per #118 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is added to addressed the possible HTTP client hanging issues mentioned in ballerina-platform/ballerina-library#5714 when using the connector.
Related to https://github.com/wso2-enterprise/internal-support-ballerina/issues/764
One line release note:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Security checks