Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Option configures to optional fields #1109

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

daneshk
Copy link
Member

@daneshk daneshk commented Feb 8, 2024

Purpose

Related Issue: ballerina-platform/ballerina-library#5715
Fixes: ballerina-platform/ballerina-library#6038

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (4774e26) to head (ba438cd).
Report is 254 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1109      +/-   ##
============================================
- Coverage     80.06%   79.93%   -0.14%     
  Complexity       66       66              
============================================
  Files            11       11              
  Lines           291      289       -2     
  Branches         69       69              
============================================
- Hits            233      231       -2     
  Misses           28       28              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Feb 24, 2024
@daneshk daneshk removed the Stale label Feb 26, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Mar 12, 2024
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Mar 15, 2024
@daneshk daneshk removed the Stale label Mar 21, 2024
@daneshk daneshk reopened this Jul 8, 2024
@daneshk daneshk requested a review from Bhashinee July 8, 2024 07:46
@daneshk daneshk merged commit 4e012b9 into ballerina-platform:master Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make jdbc:Options configurations to optional fields instead of optional types
2 participants