Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ballerinax/h2.driver instead of H2 driver jar #990

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

kaneeldias
Copy link
Contributor

Purpose

$subject

This PR also removes the native configs which are now bundles with the driver module

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@kaneeldias kaneeldias force-pushed the driver branch 2 times, most recently from 7c570f8 to 39d8d34 Compare July 27, 2023 09:04
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c0dc22b) 80.75% compared to head (4c87a96) 80.75%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #990   +/-   ##
=========================================
  Coverage     80.75%   80.75%           
  Complexity       67       67           
=========================================
  Files            11       11           
  Lines           291      291           
  Branches         69       69           
=========================================
  Hits            235      235           
  Misses           27       27           
  Partials         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaneeldias kaneeldias marked this pull request as ready for review July 27, 2023 11:26
@kaneeldias kaneeldias marked this pull request as draft July 27, 2023 11:26
@kaneeldias kaneeldias marked this pull request as ready for review July 28, 2023 07:14
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaneeldias kaneeldias merged commit b131015 into ballerina-platform:master Jul 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants