Merge pull request #76 from ayeshLK/jms-revamp

Remove `jms:createConnection` API

README.md

@@ -33,10 +33,10 @@ The following Ballerina program sends messages to a queue named *MyQueue*.
 import ballerinax/java.jms;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageProducer producer = check session.createProducer(queue);
@@ -54,10 +54,10 @@ import ballerinax/java.jms;
 import ballerina/log;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageConsumer consumer = check session.createConsumer(queue);

ballerina/Ballerina.toml

@@ -1,7 +1,7 @@
 [package]
 org = "ballerinax"
 name = "java.jms"
-version = "0.1.0"
+version = "0.1.1"
 authors = ["Ballerina"]
 keywords = ["jms"]
 repository = "https://github.com/ballerina-platform/module-ballerina-java.jms"
@@ -12,8 +12,8 @@ distribution = "2201.6.0"
 [[platform.java11.dependency]]
 groupId = "io.ballerina.stdlib"
 artifactId = "java.jms-native"
-version = "0.1.0"
-path = "../native/build/libs/java.jms-native-0.1.0.jar"
+version = "0.1.1"
+path = "../native/build/libs/java.jms-native-0.1.1-SNAPSHOT.jar"
 
 [[platform.java11.dependency]]
 groupId = "org.slf4j"

ballerina/Dependencies.toml

@@ -57,7 +57,7 @@ dependencies = [
 [[package]]
 org = "ballerinax"
 name = "java.jms"
-version = "0.1.0"
+version = "0.1.1"
 dependencies = [
  {org = "ballerina", name = "jballerina.java"},
  {org = "ballerina", name = "log"}

ballerina/Module.md

@@ -28,10 +28,10 @@ The following Ballerina program sends messages to a queue named *MyQueue*.
 import ballerinax/java.jms;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageProducer producer = check session.createProducer(queue);
@@ -49,10 +49,10 @@ import ballerinax/java.jms;
 import ballerina/log;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageConsumer consumer = check session.createConsumer(queue);

ballerina/Package.md

@@ -27,10 +27,10 @@ The following Ballerina program sends messages to a queue named *MyQueue*.
 import ballerinax/java.jms;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageProducer producer = check session.createProducer(queue);
@@ -48,10 +48,10 @@ import ballerinax/java.jms;
 import ballerina/log;
 
 public function main() returns error? {
- jms:Connection connection = check jms:createConnection({
- initialContextFactory: "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
- providerUrl: "tcp://localhost:61616"
- });
+ jms:Connection connection = check new (
+ initialContextFactory = "org.apache.activemq.jndi.ActiveMQInitialContextFactory",
+ providerUrl = "tcp://localhost:61616"
+ );
  jms:Session session = check connection->createSession({acknowledgementMode: "AUTO_ACKNOWLEDGE"});
  jms:Destination queue = check session->createQueue("MyQueue");
  jms:MessageConsumer consumer = check session.createConsumer(queue);

ballerina/connection.bal

@@ -83,10 +83,6 @@ public type ConnectionConfiguration record {|
  map<string> properties = {};
 |};
 
-public isolated function createConnection(ConnectionConfiguration c) returns Connection|error{
- return new Connection(c);
-}
-
 isolated function createJmsConnection(string initialContextFactory, string providerUrl, 
  string connectionFactoryName, map<string> otherPropeties) returns handle|error = @java:Method {
  'class: "io.ballerina.stdlib.java.jms.JmsConnectionUtils"