Update build scripts #794
Closed
Update build scripts #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashikam
added
the
Skip GraalVM Check
| @@ -0,0 +1,122 @@ | |||
| name: Build with Ballerina Lang | |||
There was a problem hiding this comment.
Do we need this workflow? Does the other ballerinax connectors have this workflow?
There was a problem hiding this comment.
I got these workflows from the ballerinax/kafka connector, since these have the compiler plugin I was asked to add the standard library workflows. https://github.com/ballerina-platform/module-ballerinax-kafka/blob/master/.github/workflows/build-with-ballerina-lang.yml
| @@ -17,12 +17,12 @@ jobs: | |||
| with: | |||
| distribution: 'temurin' | |||
| java-version: 17.0.7 | |||
|
|
|||
| - name: Set environment variable | |||
There was a problem hiding this comment.
This is workflow is not centralized. Is this because this module has compiler plugin?
There was a problem hiding this comment.
MohamedSabthar
approved these changes
Feb 28, 2024
| @@ -23,15 +23,6 @@ plugins { | |||
| id "net.researchgate.release" version "2.8.0" | |||
There was a problem hiding this comment.
Shall we move the plugin management to the settings.gradle file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes:
Examples
Checklist