Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build scripts #795

Merged
merged 10 commits into from
Mar 29, 2024
Merged

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented Mar 26, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#6240

Notes

The issue we faced earlier with docker server not running for the test module was fixed with following lines.

test.mustRunAfter startNatsServersForTests
task ballerinaTest {
    dependsOn(":${packageName}-ballerina:build")
    dependsOn(updateTomlFiles)
    dependsOn(startNatsServersForTests) // Adding this line
    dependsOn(initializeVariables)
    finalizedBy(commitTomlFiles)
    
    // Remaining task configuration...
}

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@aashikam aashikam force-pushed the build-scripts branch 2 times, most recently from f2f49d1 to d7a2fcd Compare March 26, 2024 15:50
@aashikam aashikam marked this pull request as ready for review March 26, 2024 15:53
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (11cf770) to head (561da40).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #795      +/-   ##
============================================
- Coverage     80.86%   80.79%   -0.08%     
- Complexity        0      134     +134     
============================================
  Files            30       38       +8     
  Lines          1223     1609     +386     
  Branches        149      251     +102     
============================================
+ Hits            989     1300     +311     
- Misses          168      194      +26     
- Partials         66      115      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashikam aashikam added the Skip GraalVM Check This will skip the GraalVM compatibility check label Mar 26, 2024
.github/workflows/daily-build.yml Outdated Show resolved Hide resolved
.github/workflows/daily-build.yml Outdated Show resolved Hide resolved
Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@aashikam aashikam merged commit c24f3e4 into ballerina-platform:master Mar 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate NATS build scripts to use centralized workflows
4 participants