Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated nats:Message usages #797

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented Apr 1, 2024

Purpose

Fixes: ballerina-platform/ballerina-library#6282

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@aashikam aashikam force-pushed the deprecate branch 2 times, most recently from b554351 to 3c26176 Compare April 3, 2024 09:02
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.48%. Comparing base (98c2dde) to head (2f3a233).

❗ Current head 2f3a233 differs from pull request most recent head 92de78f. Consider uploading reports for the commit 92de78f to get more accurate results

Files Patch % Lines
...lib/nats/basic/consumer/DefaultMessageHandler.java 79.41% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #797      +/-   ##
============================================
- Coverage     80.86%   80.48%   -0.39%     
- Complexity        0      134     +134     
============================================
  Files            30       38       +8     
  Lines          1223     1614     +391     
  Branches        149      254     +105     
============================================
+ Hits            989     1299     +310     
- Misses          168      198      +30     
- Partials         66      117      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashikam aashikam marked this pull request as ready for review April 3, 2024 11:41
@aashikam aashikam mentioned this pull request Apr 8, 2024
5 tasks
ThisaruGuruge
ThisaruGuruge previously approved these changes Apr 9, 2024
changelog.md Outdated Show resolved Hide resolved
ThisaruGuruge
ThisaruGuruge previously approved these changes Apr 9, 2024
@aashikam aashikam merged commit c043090 into ballerina-platform:master Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usages of deprecated records from APIs in NATS module
2 participants