-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for native queries #38
Merged
kaneeldias
merged 51 commits into
ballerina-platform:main
from
kaneeldias:native-query2
Aug 16, 2023
Merged
Add support for native queries #38
kaneeldias
merged 51 commits into
ballerina-platform:main
from
kaneeldias:native-query2
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle.properties
Add support for executing native queries
# Conflicts: # native/src/main/java/io/ballerina/stdlib/persist/sql/Utils.java # native/src/main/java/io/ballerina/stdlib/persist/sql/datastore/SQLProcessor.java
# Conflicts: # ballerina/Dependencies.toml # gradle.properties # native/src/main/java/io/ballerina/stdlib/persist/sql/Constants.java
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
============================================
- Coverage 83.75% 83.54% -0.21%
- Complexity 152 165 +13
============================================
Files 20 21 +1
Lines 1151 1246 +95
Branches 335 355 +20
============================================
+ Hits 964 1041 +77
- Misses 134 149 +15
- Partials 53 56 +3
☔ View full report in Codecov by Sentry. |
daneshk
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # ballerina/Ballerina.toml # ballerina/Dependencies.toml
daneshk
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#4546
Examples
Checklist