Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native queries #38

Merged
merged 51 commits into from
Aug 16, 2023

Conversation

kaneeldias
Copy link
Contributor

Purpose

Fixes: ballerina-platform/ballerina-library#4546

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

kaneeldias and others added 30 commits June 19, 2023 13:04
Add support for executing native queries
# Conflicts:
#	native/src/main/java/io/ballerina/stdlib/persist/sql/Utils.java
#	native/src/main/java/io/ballerina/stdlib/persist/sql/datastore/SQLProcessor.java
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 81.05% and project coverage change: -0.21% ⚠️

Comparison is base (3309478) 83.75% compared to head (09cc651) 83.54%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #38      +/-   ##
============================================
- Coverage     83.75%   83.54%   -0.21%     
- Complexity      152      165      +13     
============================================
  Files            20       21       +1     
  Lines          1151     1246      +95     
  Branches        335      355      +20     
============================================
+ Hits            964     1041      +77     
- Misses          134      149      +15     
- Partials         53       56       +3     
Files Changed Coverage Δ
ballerina/stream_types.bal 70.42% <75.00%> (+2.98%) ⬆️
...ina/stdlib/persist/sql/datastore/SQLProcessor.java 82.45% <81.66%> (-0.88%) ⬇️
ballerina/types.bal 100.00% <100.00%> (ø)
...in/java/io/ballerina/stdlib/persist/sql/Utils.java 90.00% <100.00%> (+2.50%) ⬆️
...a/stdlib/persist/sql/datastore/MSSQLProcessor.java 100.00% <100.00%> (ø)
...a/stdlib/persist/sql/datastore/MySQLProcessor.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaneeldias kaneeldias marked this pull request as ready for review August 15, 2023 11:03
daneshk
daneshk previously approved these changes Aug 16, 2023
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	ballerina/Ballerina.toml
#	ballerina/Dependencies.toml
@kaneeldias kaneeldias merged commit 5aee510 into ballerina-platform:main Aug 16, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for executing native queries in SQL databases
3 participants