fix(ui): fixed filtering of boolean fields (#2630)

ballerine-io · Aug 8, 2024 · 5c46a4c · 5c46a4c
1 parent 728ac11
commit 5c46a4c
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 10 deletions.
diff --git a/apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts b/apps/backoffice-v2/src/domains/business-reports/adapters/report-adapter/report-adapter.ts
diff --git a/...2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx b/...2/src/domains/business-reports/components/WebsiteLineOfBusiness/WebsiteLineOfBusiness.tsx
diff --git a/apps/kyb-app/CHANGELOG.md b/apps/kyb-app/CHANGELOG.md
@@ -1,5 +1,12 @@
 # kyb-app
 
+## 0.3.35
+
+### Patch Changes
+
+- Updated dependencies
+  - @ballerine/ui@0.5.16
+
 ## 0.3.34
 
 ### Patch Changes

diff --git a/apps/kyb-app/package.json b/apps/kyb-app/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@ballerine/kyb-app",
   "private": true,
-  "version": "0.3.34",
+  "version": "0.3.35",
   "type": "module",
   "scripts": {
     "dev": "vite",
@@ -16,7 +16,7 @@
   "dependencies": {
     "@ballerine/blocks": "0.2.12",
     "@ballerine/common": "^0.9.22",
-    "@ballerine/ui": "0.5.15",
+    "@ballerine/ui": "0.5.16",
     "@ballerine/workflow-browser-sdk": "0.6.33",
     "@lukemorales/query-key-factory": "^1.0.3",
     "@radix-ui/react-icons": "^1.3.0",

diff --git a/packages/react-pdf-toolkit/CHANGELOG.md b/packages/react-pdf-toolkit/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @ballerine/react-pdf-toolkit
 
+## 1.2.16
+
+### Patch Changes
+
+- Updated dependencies
+  - @ballerine/ui@0.5.16
+
 ## 1.2.15
 
 ### Patch Changes

diff --git a/packages/react-pdf-toolkit/package.json b/packages/react-pdf-toolkit/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@ballerine/react-pdf-toolkit",
   "private": false,
-  "version": "1.2.15",
+  "version": "1.2.16",
   "types": "./dist/build.d.ts",
   "main": "./dist/react-pdf-toolkit.js",
   "module": "./dist/react-pdf-toolkit.mjs",
@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "@ballerine/config": "^1.1.11",
-    "@ballerine/ui": "0.5.15",
+    "@ballerine/ui": "0.5.16",
     "@react-pdf/renderer": "^3.1.14",
     "@sinclair/typebox": "^0.31.7",
     "ajv": "^8.12.0",

diff --git a/packages/ui/CHANGELOG.md b/packages/ui/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @ballerine/ui
 
+## 0.5.16
+
+### Patch Changes
+
+- fixed filtering of boolean fields
+
 ## 0.5.15
 
 ### Patch Changes

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@ballerine/ui",
   "private": false,
-  "version": "0.5.15",
+  "version": "0.5.16",
   "type": "module",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/packages/ui/src/components/templates/report/adapters/report-adapter/report-adapter.ts b/packages/ui/src/components/templates/report/adapters/report-adapter/report-adapter.ts
@@ -1,7 +1,7 @@
 import { AdsProviders, severityToDisplaySeverity } from '@/components/templates/report/constants';
 import { adsProviderAdapter } from '@/components';
 import { TAdsProvider } from '@/components/templates/report/types';
-import { SeverityType } from '@ballerine/common';
+import { isNullish, SeverityType } from '@ballerine/common';
 
 const getLabel = ({ label, provider }: { label: string; provider: string }) => {
   if (label === 'page') {
@@ -67,7 +67,7 @@ export const reportAdapter = {
             })),
           };
         })
-        ?.filter((value): value is NonNullable<typeof value> => Boolean(value)),
+        ?.filter((value): value is NonNullable<typeof value> => !isNullish(value)),
       websiteLineOfBusinessAnalysis: toRiskLabels(
         report?.summary?.riskIndicatorsByDomain?.lineOfBusinessViolations,
       ),
@@ -195,7 +195,7 @@ export const reportAdapter = {
             })),
           };
         })
-        ?.filter((value): value is NonNullable<typeof value> => Boolean(value)),
+        ?.filter((value): value is NonNullable<typeof value> => !isNullish(value)),
       websiteLineOfBusinessAnalysis: toRiskLabels(
         report?.summary?.riskIndicatorsByDomain?.lineOfBusinessViolations,
       ),

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml