fix: aws secrets manager prefix

ballerine-io · Aug 1, 2024 · 8750906 · 8750906
1 parent 4b7d5b1
commit 8750906
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/services/workflows-service/src/env.ts b/services/workflows-service/src/env.ts
@@ -83,7 +83,7 @@ export const serverEnvSchema = {
  AWS_SECRETS_MANAGER_PREFIX: z
  .string()
  .optional()
- .default('customers')
+ .default('/dev/customers/')
  .describe('AWS Secrets Manager prefix'),
 };
 

diff --git a/services/workflows-service/src/secrets-manager/aws-secrets-manager.ts b/services/workflows-service/src/secrets-manager/aws-secrets-manager.ts
@@ -26,21 +26,11 @@ const SecretStringSchema = z
 
 export class AwsSecretsManager implements SecretsManager {
  private client: SecretsManagerClient;
- private environmentName: string;
  private prefix: string;
  private customerId: string;
 
- constructor({
- environmentName,
- prefix,
- customerId,
- }: {
- environmentName: string;
- prefix: string;
- customerId: string;
- }) {
+ constructor({ prefix, customerId }: { prefix: string; customerId: string }) {
  this.client = new SecretsManagerClient();
- this.environmentName = environmentName;
  this.prefix = prefix;
  this.customerId = customerId;
  }
@@ -106,6 +96,6 @@ export class AwsSecretsManager implements SecretsManager {
  }
 
  private getSecretName() {
- return `/${this.environmentName}/${this.prefix}/${this.customerId}`;
+ return `${this.prefix}${this.customerId}`;
  }
 }
diff --git a/services/workflows-service/src/secrets-manager/secrets-manager.factory.ts b/services/workflows-service/src/secrets-manager/secrets-manager.factory.ts
@@ -12,7 +12,6 @@ export class SecretsManagerFactory {
  case 'aws-secrets-manager':
  return new AwsSecretsManager({
  customerId,
- environmentName: env.ENVIRONMENT_NAME,
  prefix: env.AWS_SECRETS_MANAGER_PREFIX,
  });
  case 'in-memory':